Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link to wiki in the second slo action #52

Merged
merged 1 commit into from
May 16, 2024

Conversation

b10n1k
Copy link
Collaborator

@b10n1k b10n1k commented May 14, 2024

Copy link

github-actions bot commented May 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-16 12:50 UTC

@b10n1k b10n1k requested review from okurz, perlpunk and kalikiana and removed request for okurz and perlpunk May 14, 2024 07:14
backlogger.py Outdated Show resolved Hide resolved
backlogger.py Outdated Show resolved Hide resolved
@b10n1k b10n1k force-pushed the slo_amends branch 2 times, most recently from edf9a77 to 2edc469 Compare May 15, 2024 08:42
Use reminder_text and extend it with the expected comment to describe the
action of the second reminder. The reason of the rewording is to make obvious
that both reminders belong together.
`msg` variable is moved outside of the individual functions which perform the
reminder to avoid duplication.

https://progress.opensuse.org/issues/119176#note-23
Signed-off-by: ybonatakis <[email protected]>
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should the message now include the explanation and wiki link? Can you show an update on a example ticket or something?

@b10n1k b10n1k requested review from perlpunk, okurz and Martchus May 16, 2024 07:42
@okurz
Copy link
Member

okurz commented May 16, 2024

feels like you overlooked my question in #52 (review) . can you answer that please?

@b10n1k
Copy link
Collaborator Author

b10n1k commented May 16, 2024

So should the message now include the explanation and wiki link? Can you show an update on a example ticket or something?

I havent run it but the changes should just make the comment exactly as we agree This ticket was set to **{priority}** priority but was not updated [within the SLO period]({url}). The ticket will be set to the next lower priority **{priority}**

@kalikiana kalikiana merged commit 15d8a6f into openSUSE:main May 16, 2024
2 checks passed
slo_priorities[priority_current]["next_priority"]["name"],
poo_id))
url = "{}/{}.json".format(data["web"], poo_id)
msg = " ".join(update_slo_text.format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I execute this I think it's not what we want :D

>>> update_slo_text = "The ticket will be set to the next lower priority **{priority}**."
>>> msg = " ".join(update_slo_text.format(priority=23))
>>> msg
'T h e   t i c k e t   w i l l   b e   s e t   t o   t h e   n e x t   l o w e r   p r i o r i t y   * * 2 3 * * .'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And @b10n1k please see if you can add test coverage - since I mistakenly thought this was covered, which is why I thought it must still work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants