Fix logic for --reminder-comment-on-issues #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`store_false` will actually turn the switch *off* when used, so the logic was reversed. Apparently this is broken since b260dbb Issue: https://progress.opensuse.org/issues/157522
|
argh, forgot to push to origin instead. I guess we can ignore the failed preview workflow? |
okurz
approved these changes
Mar 19, 2024
kalikiana
requested changes
Mar 19, 2024
| @@ -275,7 +275,7 @@ def trigger_webhook(state, bad_queries): | |||
| parser.add_argument( | |||
| "--output", choices=["markdown", "influxdb"], default="markdown" | |||
| ) | |||
| parser.add_argument("--reminder-comment-on-issues", action="store_false") | |||
| parser.add_argument("--reminder-comment-on-issues", action="store_true") | |||
There was a problem hiding this comment.
The default is supposed to be false, though.
There was a problem hiding this comment.
Hrm. According to the docs the defaults are flipped? I guess it means reminder comments would only have been "sent" when they were not supposed to.
There was a problem hiding this comment.
So the alternative is probably const? Not sure either is more readable to be honest, so I guess either way is fine by me.
Suggested change
| parser.add_argument("--reminder-comment-on-issues", action="store_true") | |
| parser.add_argument("--reminder-comment-on-issues", action="store_const", const=True) |
kalikiana
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store_falsewill actually turn the switch off when used, so the logic was reversed.Apparently this is broken since b260dbb
Issue: https://progress.opensuse.org/issues/157522