Add codemeta.json #30
Conversation
Test Results464 tests 464 ✅ 1m 11s ⏱️ Results for commit b432b14. ♻️ This comment has been updated with latest results. |
ehennestad
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 37.07% 37.07%
=======================================
Files 323 323
Lines 3118 3118
=======================================
Hits 1156 1156
Misses 1962 1962 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey. I had a look (see my smaller comments) but I would suggest to pull in @apdavison as reviewer.
| "description": "openMINDS MATLAB is a toolbox to support the creation and use of openMINDS metadata models and schemas in MATLAB, with import and export in JSON-LD format. The package contains all openMINDS schemas as MATLAB classes in addition to schema base classes and utility methods.", | ||
| "applicationCategory": "neuroscience", | ||
| "releaseNotes": "https://github.com/openMetadataInitiative/openMINDS_MATLAB/releases", | ||
| "funding": "https://cordis.europa.eu/project/id/945539", |
There was a problem hiding this comment.
I assume that this is not enough (depending on the version). Right now you would receive funding through EBRAINS 2.0 I guess?
There was a problem hiding this comment.
should this not be an array? with funder inside? not sure how codemeta handles this...
| "version": "0.9.3", | ||
| "downloadUrl": "https://github.com/openMetadataInitiative/openMINDS_MATLAB/releases/download/v0.9.3/openMINDS_MATLAB_v0_9_3.mltbx", | ||
| "dateModified": "2024-10-01" | ||
| } |
There was a problem hiding this comment.
should have an empty line at the end
| function mustBeValidVersionString(versionString) | ||
| pattern = 'v\d+\.\d+\.\d+'; | ||
| assert( ~ismissing( regexp(versionString, pattern, 'match', 'once')), 'Invalid version string. Must be formatted as v<major>.<minor>.<patch>' ) | ||
| end |
There was a problem hiding this comment.
should have an empty line at the end
| "softwareRequirements": [ | ||
| "MATLAB R2022b or later" | ||
| ], | ||
| "relatedLink": [ |
There was a problem hiding this comment.
instead or in addition you could define isPartOf since this repo is part of the open metadata initiative organisation on github
Issue #23