Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trace file player and trace file writer in pipeline #73

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Fix trace file player and trace file writer in pipeline #73

merged 3 commits into from
Dec 15, 2023

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Dec 12, 2023 •
edited
Loading

Add a description

  • The trace file player FMU install directory was updated in the trace file player repo. The FMU location is updated with this PR.
  • The trace file writer input parameters were renamed.
  • Add alternate text to readme images, as this is a new rule for the markdown linter.

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

@ClemensLinnhoff ClemensLinnhoff requested a review from a team December 12, 2023 09:17
@ClemensLinnhoff ClemensLinnhoff changed the title Fix trace file player location in pipeline Fix trace file player and trace file writer in pipeline Dec 12, 2023
@ClemensLinnhoff ClemensLinnhoff merged commit 6c9be5b into main Dec 15, 2023
20 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the update-trace-file-player branch December 15, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasElster LukasElster LukasElster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SL1 - Perception Sensor Models
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClemensLinnhoff @LukasElster