Remove unused param and minor touchup for assert

open-telemetry · Dec 17, 2024 · 2332906 · 2332906
1 parent fadff90
commit 2332906
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ext/test/http/curl_http_test.cc b/ext/test/http/curl_http_test.cc
@@ -538,7 +538,7 @@ struct GzipEventHandler : public CustomEventHandler
 {
   ~GzipEventHandler() override = default;
 
-  void OnResponse(http_client::Response &response) noexcept override {}
+  void OnResponse(http_client::Response & /* response */) noexcept override {}
 
   void OnEvent(http_client::SessionState state, nostd::string_view reason) noexcept override
   {
@@ -575,7 +575,7 @@ TEST_F(BasicCurlHttpTests, GzipCompressibleData)
   session->FinishSession();
   ASSERT_TRUE(handler->is_called_);
   ASSERT_EQ(handler->state_, http_client::SessionState::Response);
-  ASSERT_EQ(handler->reason_, "");
+  ASSERT_TRUE(handler->reason_.empty());
 
   auto http_request =
       dynamic_cast<opentelemetry::ext::http::client::curl::Request *>(request.get());
@@ -623,7 +623,7 @@ TEST_F(BasicCurlHttpTests, GzipIncompressibleData)
   session->FinishSession();
   ASSERT_TRUE(handler->is_called_);
   ASSERT_EQ(handler->state_, http_client::SessionState::Response);
-  ASSERT_EQ(handler->reason_, "");
+  ASSERT_TRUE(handler->reason_.empty());
 
   auto http_request =
       dynamic_cast<opentelemetry::ext::http::client::curl::Request *>(request.get());