Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@all-contributors please add @sowndappan5 for code #582

Closed
wants to merge 1 commit into from

Conversation

sowndappan5
Copy link

@sowndappan5 sowndappan5 commented Nov 26, 2024

Description

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Contributors Checklist

I've read through the Getting Started section

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

[optional] What GIF best describes this PR or how it makes you feel?

@sowndappan5 sowndappan5 requested a review from a team as a code owner November 26, 2024 13:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@adiati98
Copy link
Member

Hey @sowndappan5,
We appreciate your contribution. ✨

However, we will close this PR with following reasons:

  • You made changes directly in the main branch, and we don't want that.
  • There is no changes that meets our requirement in this PR. Please read and follow the instruction in the "Let's Get Practical" section of our Intro to Open Source course to contribute to this repo.

Feel free to open a new issue and PR once you've understand the instructions. Thank you. πŸ™‚

@adiati98 adiati98 closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants