-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU extension detection for arm64 on NetBSD. #1876
base: main
Are you sure you want to change the base?
Conversation
Joint work with Keelan Cannoo, Jeevesh Dindyal & UoM RICRG. Signed-off-by: Loganaden Velvindron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than some style things. @SWilson4 Do we have a NetBSD CI setup to check that this works as expected? Do we currently sanity check CPU extensions in CI?
Signed-off-by: Loganaden Velvindron <[email protected]>
Nope, no NetBSD setup. It seems like something that would be nice to have to support ongoing work on porting liboqs to NetBSD. I believe that there is also no sanity checking of CPU extensions, though it might be hidden somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this turn "stale"? @Martyrshot @SWilson4 @loganaden ? Any interest to still land this? If so, please also update PLATFORMS.md suitably. If not, please close.
we need to get the NetBSD runner up. I will get back to this. I got delayed a bit. It has landed in NetBSD pkgsrc however: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/security/liboqs/patches/patch-common.c?rev=1.1;content-type=text%2Fx-csrc. |
Joint work with Keelan Cannoo, Jeevesh Dindyal & UoM RICRG.