Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Keep using node 16 #3151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix] Keep using node 16 #3151

wants to merge 2 commits into from

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Jul 18, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Allow node 16 in actions: checkout@v3 using node20 instead of node16 actions/checkout#1809
  2. Fix mypy-mirror in pre-commit hook Pre-commit fails to run when typed_ast needs to be built. pre-commit/pre-commit#2850

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HAOCHENYE HAOCHENYE requested a review from zhouzaida July 19, 2024 06:52
@HAOCHENYE HAOCHENYE force-pushed the fix-ci branch 3 times, most recently from ccec643 to 4796e63 Compare July 19, 2024 07:53
@@ -1,5 +1,6 @@
name: merge_stage_test

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Collaborator

@zhouzaida zhouzaida Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the Node20?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants