Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support SDXL training #2040

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

okotaku
Copy link
Contributor

@okotaku okotaku commented Sep 21, 2023

Motivation

Support SDXL training.

Related PR: open-mmlab/mmengine#1361

Use cases (Optional)

mim train mmagic configs/stable_diffusion_xl/stable-diffusion_xl_pokemon_blip.py

Results

stable-diffusion_xl_pokemon_blip

fake_img_10

weight: https://drive.google.com/file/d/1fzJwdW2yBjEqBDdQ1ILvQ23eVBK43jLO/view?usp=sharing

stable-diffusion_xl_lora_pokemon_blip

fake_img_10

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@okotaku
Copy link
Contributor Author

okotaku commented Sep 21, 2023

Why do so many cpu tests fail, including some that have not been changed?

https://github.com/open-mmlab/mmagic/actions/runs/6258709202/job/16993265761?pr=2040#step:10:4026

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmagic/datasets/__init__.py 100.00% <100.00%> (ø)
mmagic/datasets/transforms/__init__.py 100.00% <100.00%> (ø)
mmagic/engine/hooks/__init__.py 100.00% <100.00%> (ø)
mmagic/models/archs/lora.py 15.06% <100.00%> (ø)
...gic/models/data_preprocessors/data_preprocessor.py 97.41% <100.00%> (ø)
mmagic/engine/hooks/visualization_hook.py 95.53% <85.71%> (+1.31%) ⬆️
mmagic/datasets/transforms/loading.py 91.10% <78.12%> (-2.04%) ⬇️
mmagic/datasets/transforms/sdxl.py 93.06% <93.06%> (ø)
...magic/engine/hooks/lora_checkpoint_to_save_hook.py 56.25% <56.25%> (ø)
...editors/stable_diffusion_xl/stable_diffusion_xl.py 13.20% <0.00%> (-0.27%) ⬇️
... and 1 more

📢 Thoughts on this report? Let us know!.

@okotaku
Copy link
Contributor Author

okotaku commented Sep 23, 2023

I am fixing the test error on mmengine PR.
open-mmlab/mmengine#1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants