-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debatts Some Code #295
base: main
Are you sure you want to change the base?
Conversation
Who Can Review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a README to introduce Debatts, also an env.sh about environment configuration file if needed.
models/tts/debatts/t2s_model_new.py
Outdated
@torch.no_grad() | ||
def sample_hf( | ||
self, | ||
phone_ids, # the phones of prompt and target should be concatenated together。在实际使用中,phone_ids是文本的token输入 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use English comments in the code. It's the same for other files.
models/tts/debatts/utils/tool.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use English comments.
models/tts/debatts/utils/logger.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use English comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use English comments.
models/tts/debatts/environment.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a simple env.sh file, you can follow https://github.com/open-mmlab/Amphion/blob/main/models/tts/maskgct/env.sh
✨ Description
[Please describe the background, purpose, changes made, and how to test this PR]
🚧 Related Issues
[List the issue numbers related to this PR]
👨💻 Changes Proposed
🧑🤝🧑 Who Can Review?
[Please use the '@' symbol to mention any community member who is free to review the PR once the tests have passed. Feel free to tag members or contributors who might be interested in your PR.]
🛠 TODO
✅ Checklist