Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nebula participants to the website #909

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Oct 19, 2024

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

This PR fixes issue #908.
Changes made:

  • Fixed failure from logic in open-seeds/about.md - line 296.
  • Added experts

To be done:

  • Display previous cohorts
  • Add mentees, mentors and projects

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit f25df19
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/6724b32b12f244000870dd9e
😎 Deploy Preview https://deploy-preview-909--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NPDebs NPDebs marked this pull request as ready for review November 1, 2024 10:55
@yochannah yochannah requested a review from bebatut November 7, 2024 15:09
@iramosp
Copy link
Member

iramosp commented Nov 26, 2024

@NPDebs, thanks for working on this! I looked at the deploy preview, and I have a couple of comments:

  1. All experts and participants from the pilot seem to be on the subpage, but they all show up as experts. Is the information we have on Civi enough to assign the correct roles to each individual?
  2. Can we also add facilitators?
  3. For consistency, we are using the term "Participants" rather than "Mentees" for Nebula. Is it possible to change this in the subpage?
  4. Follow-up question: I have some ideas about updating the template text for each cohort subpage, for example, having Nebula-specific role descriptions and goals. I think this should go in another issue, but for now, could you point me to the right file I should look at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants