-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement merge shuffle algorithm for Numba #991
base: main
Are you sure you want to change the base?
Conversation
Thank you, @zengraf! I suggest to:
|
While looking at the changes today with @abulenok (trying to understand the reasons for the breakup test failures), we came up with the idea to create a unit test aimed at checking if the generated permutations have indeed a uniform distribution - would be a great addition! |
Hey @piotrbartman, |
Yes, definitely. The current implementation of |
@piotrbartman Thanks for following up! |
Stale pull request message |
Co-authored-by: Sylwester Arabas <[email protected]>
Co-authored-by: Sylwester Arabas <[email protected]>
bc0ba70
to
8e94031
Compare
Stale pull request message |
Stale pull request message |
Stale pull request message |
Stale pull request message |
This is an implementation of a parallel shuffling algorithm called Merge Sort and is a follow-up to #964.
The algorithm
Please, note that merging step requires
n * Math.ceil(log2(n / 1048576))
more random numbers