Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs-generating script that allows for specifying input and output path #1466

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

Sfonxu
Copy link
Collaborator

@Sfonxu Sfonxu commented Dec 13, 2024

regarding #1445

@Sfonxu Sfonxu changed the title added docs-generating script add docs-generating script that allows for specifying input and output path Dec 13, 2024
@Sfonxu Sfonxu requested a review from slayoo December 13, 2024 08:12
.github/workflows/docs.py Outdated Show resolved Hide resolved
.github/workflows/docs.py Outdated Show resolved Hide resolved
.github/workflows/docs.py Outdated Show resolved Hide resolved
.github/workflows/docs.py Outdated Show resolved Hide resolved
@slayoo
Copy link
Member

slayoo commented Dec 13, 2024

Thanks @Sfonxu! I've added a few comments that could help make the code more bullet-proof

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (665f5ad) to head (b8a9038).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1466   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9266           
=======================================
  Hits         7897     7897           
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@slayoo slayoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Sfonxu !

@slayoo slayoo added this pull request to the merge queue Dec 22, 2024
Merged via the queue into main with commit 5a49cb0 Dec 22, 2024
186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants