Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump devops_tests to include checks for badge presence and Colab header cell #1403

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Oct 19, 2024

No description provided.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (a2a7157) to head (aa4f5f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1403   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         375      375           
  Lines        9252     9252           
=======================================
  Hits         7855     7855           
  Misses       1397     1397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo force-pushed the bump_devops_tests branch from 71b54ea to 9f695b6 Compare October 27, 2024 14:39
@slayoo
Copy link
Member Author

slayoo commented Nov 11, 2024

OK, this PR gets much higher priority now - without the new checks we cannot rely on badge presence in the first header cell, what results in fishy docs contents, e.g.:
image

@AgnieszkaZaba
Copy link
Collaborator

AgnieszkaZaba commented Nov 12, 2024

I think we should change devops_tests, because in probably every notebook we wrote View on Github instead of preview. So it will be easier to change test.

Edit: I changed name of the badge in notebooks in PySDM as suggested in devops_tests PR#38
Thanks to @slayoo and @Delcior!

@AgnieszkaZaba
Copy link
Collaborator

@slayoo, I don't know how to resolve this. I think it is due to different changes in the same files on your fork and PySDM repository.

@slayoo
Copy link
Member Author

slayoo commented Nov 13, 2024

@slayoo, I don't know how to resolve this. I think it is due to different changes in the same files on your fork and PySDM repository.

@AgnieszkaZaba, the conflicting file was renamed on the main branch of open-atmos in a recent PR, which was causing the conflict. Resolved.

@slayoo
Copy link
Member Author

slayoo commented Nov 13, 2024

Thank you @AgnieszkaZaba!

@slayoo slayoo merged commit 83b1edd into open-atmos:main Nov 13, 2024
142 of 147 checks passed
@slayoo slayoo mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants