Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw=True flag for attribute saving in S&H example #1385

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Sep 3, 2024

this addresses the lack of a way to access unaltered super-droped ids reported in #1380

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (ec1f515) to head (303dc30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files         373      373           
  Lines        9160     9160           
=======================================
  Hits         7722     7722           
  Misses       1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member Author

slayoo commented Sep 5, 2024

TODOs:

  • create a test that will fail without this change
  • make the new behaviour controllable from user scope

@slayoo slayoo marked this pull request as draft November 24, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant