Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visualisation of threading domain decomposition to cartesian scenario quick_look (incl. README animations) #110

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Mar 27, 2024

No description provided.

@slayoo slayoo requested a review from Delcior March 27, 2024 00:31
@slayoo
Copy link
Member Author

slayoo commented Mar 27, 2024

this is how it looks:
step=0001
step=0001

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 68.92%. Comparing base (f0c3589) to head (8eb3391).

Files Patch % Lines
scenarios/cartesian.py 20.00% 16 Missing ⚠️
.../local/contract_tests/test_single_vs_multi_node.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   71.14%   68.92%   -2.23%     
==========================================
  Files          20       20              
  Lines         454      473      +19     
==========================================
+ Hits          323      326       +3     
- Misses        131      147      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member Author

slayoo commented Mar 29, 2024

let's merge to be able to see the animations in the README, and then let's later discuss how to refactor the quick_look code

@slayoo slayoo merged commit 38e0706 into open-atmos:main Mar 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants