Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS: Fix loadGeoPossibilities #608

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Dec 15, 2020

Since mid 2018 you need an API key to use the Google maps API. If you have such a key,
store it in a file googlemaps_api_key.txt in the same directory as add_library.py
(this file is not checked into version control).
If you don't have a Google API key, we use OSM Nominatim instead (no key required).

Since mid 2018 you need an API key to use the Google maps API. If you have such a key,
store it in a file googlemaps_api_key.txt in the same directory as add_library.py
(this file is not checked into version control).
If you don't have a Google API key, we use OSM Nominatim instead (no key required).
to make it work with add_auto_libraries.py and geoloc.py too where
it is imported from add_library.py.
@johan12345
Copy link
Collaborator

Looks good to me, thanks! We don't really use these tools ourselves anymore, as we have a new one integrated into the web server which serves the configuration files - but it's still good to keep them at least in a usable state.

@johan12345 johan12345 merged commit c24f935 into opacapp:master Jan 4, 2021
@StefRe
Copy link
Contributor Author

StefRe commented Jan 9, 2021

I just needed the tool as for the new PrimoExplore API where I'll have to add quite a number of keys from the Primo config file to the JSON configuration.

We don't really use these tools ourselves anymore, as we have a new one integrated into the web server which serves the configuration files

Is this new tool publically accessible? If so then the Wiki page Adding a new library should be updated as it refers to the python scripts.

@StefRe StefRe deleted the fix/add_library branch January 9, 2021 11:03
@johan12345
Copy link
Collaborator

No, that is not publically accessible as it saves the configuration files directly to our database. I added some more information to the wiki page now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants