Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cicd #813

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix/cicd #813

merged 2 commits into from
Oct 30, 2023

Conversation

prnk28
Copy link
Contributor

@prnk28 prnk28 commented Oct 30, 2023

No description provided.

@prnk28 prnk28 merged commit 10c6aa6 into master Oct 30, 2023
6 of 8 checks passed
@senior-dev-bot
Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

@prnk28 prnk28 deleted the fix/cicd branch October 30, 2023 21:32
@prnk28 prnk28 added the CI-CD label Oct 30, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 30, 2023

PR Summary

  • Job Removal in Workflow
    The publish-buf job from .github/workflows/release.yml has been removed. This means that the publishing process may be streamlined or changed.

  • Configuration Update
    Modifications have been made in the build configurations in .goreleaser.yaml. The sections CC and hooks were removed, which suggests an optimization in the build process.

  • Package Renaming
    Several files namely genaccounts.go, geninit.go, gentx.go, plugin.go, plugin_default.go, and root.go underwent a change in package naming from cmd to sonrcmd. This change is often done for clarity or to avoid name conflicts.

  • File Deletion
    The cmd/sonrd/cmd/launch.go file has been deleted. This could mean the associated functionality is no longer needed in the overall codebase.

  • Import Updates
    The imports in cmd/sonrd/root.go and cmd/sonrd/main.go files have been updated to use the newly renamed sonrcmd package. This ensures that the changes accurately carry forward into these files' functionality.

@sweep-ai
Copy link

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant