Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

[codefaux]

Description of the change

• Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

Benefits

• Faster metrics collection for users not desiring History/Wanted/Missing
• Stall mitigation re: users with large collections or long-lived instances

Possible drawbacks

• I don't know Golang or koanf and did not look up reference for either, but I believe I have treated both appropriately.

Applicable issues

• Feature request: Skip History, Wanted options #298

Additional information

• Thanks for your work.

[onedr0p]

Tabs

[codefaux]

I've never used go and I'm a "spaces not tabs" person so I was unaware of the standard or that I had done it differently than yours. I ran it through gofmt, given that's the official tool I'd imagine that's your expectation. Let me know if it needs anything else.

[onedr0p]

I am also a spaces person as well, but Go has some opinions on formatting that I like to follow.

[codefaux]

Wholeheartedly agree -- if the language has a suggested standard, use it.

[onedr0p]

Changes appear good here, but I wonder if it could be added to the logic --enable-additional-metrics flag instead of creating separate config flags / env options? I am not sure if there is a use-case for why you would want --enable-additional-metrics on but turn off the history & wanted/missing flags? The --enable-additional-metrics flag was mainly created for those with large libraries that need to turn off the slower API calls.

Also @rtrox would be great if/when you are free to review to get a pair of second eyes on this.

[rtrox]

Thanks for the PR @codefaux! Sorry about the delayed review here, been dealing with some issues in RL. A few comments, but overall looks good!

[rtrox]

Given we're blocking the whole collector, can we instead put this in the Commands file, and just not register the collector?

exportarr/internal/commands/arr.go

Lines 44 to 67 in 72c2d6c

	var radarrCmd = &cobra.Command{
	Use: "radarr",
	Aliases: []string{"r"},
	Short: "Prometheus Exporter for Radarr",
	Long: "Prometheus Exporter for Radarr.",
	RunE: func(cmd *cobra.Command, args []string) error {
	c, err := config.LoadArrConfig(*conf, cmd.PersistentFlags())
	if err != nil {
	return err
	}
	c.ApiVersion = "v3"
	UsageOnError(cmd, c.Validate())
	serveHttp(func(r prometheus.Registerer) {
	r.MustRegister(
	collector.NewRadarrCollector(c),
	collector.NewQueueCollector(c),
	collector.NewHistoryCollector(c),
	collector.NewRootFolderCollector(c),
	collector.NewSystemStatusCollector(c),
	collector.NewSystemHealthCollector(c),
	)
	})
	return nil

The same config is available there as c, so you can just check c.EnableAdditionalMetrics.

[rtrox]

For Radarr & Readarr, we divine this metric instead of sending a separate call for it:

exportarr/internal/commands/arr.go

Lines 44 to 67 in 72c2d6c

	var radarrCmd = &cobra.Command{
	Use: "radarr",
	Aliases: []string{"r"},
	Short: "Prometheus Exporter for Radarr",
	Long: "Prometheus Exporter for Radarr.",
	RunE: func(cmd *cobra.Command, args []string) error {
	c, err := config.LoadArrConfig(*conf, cmd.PersistentFlags())
	if err != nil {
	return err
	}
	c.ApiVersion = "v3"
	UsageOnError(cmd, c.Validate())
	serveHttp(func(r prometheus.Registerer) {
	r.MustRegister(
	collector.NewRadarrCollector(c),
	collector.NewQueueCollector(c),
	collector.NewHistoryCollector(c),
	collector.NewRootFolderCollector(c),
	collector.NewSystemStatusCollector(c),
	collector.NewSystemHealthCollector(c),
	)
	})
	return nil

I wonder if we should do something similar for Lidarr & Sonarr, instead of just turning it off. @codefaux - if you're up for taking a stab that, that would be great. Otherwise, I'm happy with us putting this behind a flag for now, and I can create a ticket to add it back by mathing it.

[rtrox]

minor nit: can we leave the metric emission immediately below where it's collected, like we did before? So move line 285 here.