Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe: increase concat lws[0] size w/new optimal calculation #2315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syurkevi
Copy link
Contributor

Description

This PR adresses performance regressions discovered as part of regular monitoring by increasing the lws[0] as much as possible. The new get_optimal_lws() logic is biased towards a more n-dimensional lws. Removing the requested vectorization axis (-1) will create a lws[0] as large as possible. If maximizing lws[0] will cause new slowdowns an updated reverted get_optimal_lws() will be used instead.

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?
    image

@syurkevi syurkevi requested a review from a team as a code owner December 24, 2024 16:48
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Dec 24, 2024
@syurkevi
Copy link
Contributor Author

make test perf-gpu
set primitive=concat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant