src: handle DNNL_VERBOSE=OFF support through an early exit (fixes MFDNN-12862) #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled verbose shouldn't print data even if requested. The change is complied with this requirement with a marginal price of the library size for disabled verbose build, but easier way to support this mode.
github-actions
bot
added
platform:cpu-x64
|
make test |
mgouicem
reviewed
Dec 20, 2024
| return std::string(); | ||
| } | ||
|
|
||
| void verbose_printf_impl(const char *raw_fmt_str, verbose_t::flag_kind kind) {} |
There was a problem hiding this comment.
Could you clarify why these were not enough? At a glance, it seems that under DISABLE_VERBOSE, the behavior after the patch should be similar (return empty string or empty function).
There was a problem hiding this comment.
The number of functions was growing, they are used across different places in verbose-reporting functionality. I decided that instead of handling each function under if (disabled) section (including future added) separately, it's just easier to force some of them to return empty strings under that build flag and call it a day. Should be no issues with future functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MFDNN-12862
Disabled verbose shouldn't print data even if requested. The change is complied with this requirement with a marginal price of the library size for disabled verbose build, but easier way to support this mode.