feat: Remove BufReader req for GitOid construction #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we required buffering when constructing a GitOid from a file, but this isn't always desirable. This commit makes the API generic over any reader, and also updates the FFI to make buffering optional. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
added
type: feature
GitHub Codespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we required buffering when constructing a GitOid
from a file, but this isn't always desirable. This commit makes
the API generic over any reader, and also updates the FFI to
make buffering optional.
Signed-off-by: Andrew Lilley Brinker [email protected]
Closes #79