Update release.yml #95
Conversation
Fix for the publishing Github action.
There was a problem hiding this comment.
Apologies, we made a small error here. You've identified the problem correctly, but the problem is related to not using the poetry virtual environment to get the package version.
There is also an additional issue that will not be solved by this PR. The tag used in the most recent release was v1.0.1, but the version in the pyproject.toml is 1.1.0, which means this workflow will fail anyway
Updated to reflect Adrian's requested changes
removed dependency installation step as per review comments.
|
Edited the latest release to use the v1.1 tag to align with the pyproject.toml configuration, as I assume this was the intended release number. Combined with the changes made after review change requests, fingers crossed this sorts the problem out. |
There was a problem hiding this comment.
I believe this is all good to go!
The release tag will need to be changed to v1.1.0 so it is a valid semantic version string (all three numbers are always required). Also, the associated release action will need to be re-run if changing the release tag does not trigger a re-run
Fix for the publishing Github action.
Due to the nature of the action, this could need another change, but due to the error thrown this should get past the wheel building.