Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pmc config update #92

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

Thomas-Rowlands
Copy link
Collaborator

@Thomas-Rowlands Thomas-Rowlands commented Nov 28, 2024

Description

Added new PMC config file for the October PMC website changes.

Moved config files to inside the autocorpus module, ready for use within a packages Auto-CORPus on PyPI.

Updated regression test to use an updated new directory structure.

Updated Readme to reflect directory changes.
Fixes 78 (issue)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • [] Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. pytest)
  • The documentation builds and looks OK (eg. mkdocs)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Thomas-Rowlands and others added 2 commits November 28, 2024 18:21
Moved config files to inside the autocorpus module.

Updated regression test to use an updated new directory structure.

Updated Readme to reflect directory changes.
Copy link
Contributor

@jmp111 jmp111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new config with old installation of AC as well, able to produce the right output

@Thomas-Rowlands Thomas-Rowlands merged commit 2290832 into omicsNLP:main Dec 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants