-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pathlib for path handling #57
Conversation
Thanks for this @tsmbland! The only problem is that this PR and your other one are likely to cause merge conflicts with @Thomas-Rowlands' mega-PR (#20). We've got a meeting with the team today, so hopefully we'll be able to figure out a strategy to get all the PRs merged together. With your |
Ah ok I didn't spot that! Very few manual fixes were required. See this commit |
Yeah, sorry I didn't make it clear in the issue descriptions 😞. Hopefully we should just be able to merge it with your work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good :)
@Thomas-Rowlands There are now a bunch of merge conflicts with #20. See my comments above |
Indeed, #20 is very old at this point and has such a large amount of changes I would expect nothing less. Unfortunately as #20 also contains intended changes to the way table processing is handled, for example, I'm not certain the regression test would be a guarantee of success. #20 will need to be picked through with a fine-toothed comb after merging locally, so this may take a while. Speak shortly in the Teams meeting. |
Okey doke. Speak soon then. |
This PR aims to make full use of the inbuilt
pathlib
module to handle paths, which were previously being passed around as strings. Mostly this is to ensure compatibility on different operating systems, but the syntax is also tidier and makes the code a bit more readable.The tests pass locally, although the testing suite is minimal, so I'm sure someone will want to try this out more thoroughly before merging
Close #39