feat: introduce matchSource match template variable

[miurahr]

split of #963

Pull request type

• Feature enhancement -> [enhancement]

Which ticket is resolved?

RFE#1251

What does this PR change?

• Change default fuzzy match pane template with matchSource
• Add method MatchesVarExpansion#expandMatchSource
• Extend NearString.MATCH_SOURCE to have TM_SUBSEG
• Update test expectations of MatchesTextAreaTest, and FindMatchesTest
• Add human-readable names of MATCH_SOURCE in Bundle.properties

Other information

[github-actions]

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/xqvgpqtwhvm26

[github-actions]

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/bj5i5ehblv3xm

[github-actions]

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/h4ltp4n7ujf5c

[miurahr]

The acceptance test error is

java.lang.AssertionError: [org.omegat.gui.matches.MatchesTextArea[name='matches_pane', text='1. Error while reading MT results	
Erreur lors de la lecture des résultats de TA	
<20/20/30%From Project>', enabled=true, visible=true, showing=true] - property:'text'] 	
Expecting actual:	
  "1. Error while reading MT results	
Erreur lors de la lecture des résultats de TA	
<20/20/30%From Project>"	
to match pattern:	
  "1. Error while reading MT results\nErreur lors de la lecture des résultats de TA\n<\d+/\d+/\d+%\s*>"

[miurahr]

I have updated bundle keys and test expectation.
During process I merged the master branch.

[miurahr]

I have updated bundle keys and test expectation. During process I merged the master branch.

With new changes, the part of "<50/50/60% >" will become like

1. "<50/50/60% Project>"
2. "<50/50/60% External TMX tm/penalty-010/segment.tmx>"
3. "<50/50/60% Source files source/foo.po>"
4. "<50/50/60% Sub-segmented match>"

@t-cordonnier @brandelune is the resulted change suitable for your assumption?

When #1226 is merged, No4 will become like "<50/50/60% Sub-segmented match tm/file1.tmx,tm/file2.tmx>"

[brandelune]

I have updated bundle keys and test expectation. During process I merged the master branch.

With new changes, the part of "<50/50/60% >" will become like

1. "<50/50/60% Project>"
2. "<50/50/60% External TMX tm/penalty-010/segment.tmx>"
3. "<50/50/60% Source files source/foo.po>"
4. "<50/50/60% Sub-segmented match>"

@t-cordonnier @brandelune is the resulted change suitable for your assumption?

When #1226 is merged, No4 will become like "<50/50/60% Sub-segmented match tm/file1.tmx,tm/file2.tmx>"

Ok. So we should first modify the second item in that representation of the match pane this way:

<50/50/60% >

→

<50/50/60% Project>

Is that correct ?

In the case of orphan segments (we should not has a plural here, right @Kazephil), what will be the display ? Since orphan matches all come from the project file, there will be a double indication.

Regarding the various labels:

1. "<50/50/60% Project>"

Ok for now.

2. "<50/50/60% External TMX tm/penalty-010/segment.tmx>"

should be External TM: <path> since all bilingual files are accepted in the /tm folder, not exclusively TMX files.

3. "<50/50/60% Source files source/foo.po>"

should be Source file: <path>

4. "<50/50/60% Sub-segmented match>"

not easy to understand. What about

Reconstructed match, Merged match, etc.

@t-cordonnier, what do you think about all that?

[miurahr]

Answer the question.

In the case of orphan segments (we should not has a plural here, right @Kazephil), what will be the display ? Since orphan matches all come from the project file, there will be a double indication.

Current master branch has been programmed to store localized of "Orphan segments" as a TMX name field.
The message is defined in the Bundle with the key "CT_ORPHAN_STRINGS".

see.

omegat/src/org/omegat/core/statistics/FindMatches.java

Line 247 in 3ea0c12

String fileName = project.isOrphaned(source) ? ORPHANED_FILE_NAME : null;

It may become fuzzy match pane to show

<50/50/60% Project Orphan segments>

Requested changes are done.

[miurahr]

Suggested change

	"MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_TM_SUBSEG") + " ");
	"MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_SUBSEGMENTS") + " ");

[miurahr]

Suggested change

	MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_TM_SUBSEG=Sub-segmented match
	MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_SUBSEGMENTS=Sub-segmented match