chore: CheckStyle checks copyright notice header #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckStyle has a directive RegexpHeader since checkstyle version 6.9. We can use it for check copyright notice in source header Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckStyle version 6.9 and onward support RexexpHeader module that checks header copyright notice.
We do not need to write the checker by our selves.
Pull request type
What does this PR change?
Other information
The change will speedup unit tests because the copyright check is done in checkstyle process at once