feat: dictionary as language module #1185
Conversation
Signed-off-by: Hiroshi Miura <[email protected]>
… copy to a file system Signed-off-by: Hiroshi Miura <[email protected]>
- Add API installHunspellDictionary(Path dictionaryDir) - Support it on AR, DA and FR - Provide bundled dictionary on FR Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/spell-checker/dictionary-as-language-module
branch
from
a51e221 to
66799c8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
miurahr
force-pushed
the
topic/miurahr/spell-checker/dictionary-as-language-module
branch
from
41b598e to
33ec2ec
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/spell-checker/dictionary-as-language-module
branch
from
d05df47 to
213cfed
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
- explain the folder for user CUSTOM spelling dictionary - explain the language module will install the spelling dictionary when necessary. - update explaination of the spelling preference Signed-off-by: Hiroshi Miura <[email protected]>
- Remove URL box and install/uninstall buttons - Remove DictionaryInstallerDialog - clean bundles Signed-off-by: Hiroshi Miura <[email protected]>
- Extend SpellCheckerManager to return supported languages - Update DictionaryManager#getLocalDictionaryCodeList to return languages from language modules Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
requested review from
Kazephil,
brandelune and
kosivantsov
as code owners
| @@ -0,0 +1,237 @@ | |||
| # How to publish a spell check dictionary as plugin | |||
|
|
|||
| #### Overview | |||
There was a problem hiding this comment.
| #### Overview | |
| ## Overview |
Level of section title is wrong
| This document provides guidance on creating a plugin, explaining the purpose of the interface methods, | ||
| and giving practical tips for implementation. | ||
|
|
||
| #### `ISpellCheckDictionary` Interface |
There was a problem hiding this comment.
| #### `ISpellCheckDictionary` Interface | |
| ## `ISpellCheckDictionary` Interface |
| } | ||
| ``` | ||
|
|
||
| #### Method Descriptions |
There was a problem hiding this comment.
| #### Method Descriptions | |
| ### Method Descriptions |
| } | ||
| ``` | ||
|
|
||
| #### Example Implementation |
There was a problem hiding this comment.
| #### Example Implementation | |
| ### Example Implementation |
| These plugins must implement the `ISpellCheckDictionary` interface, which defines the necessary methods | ||
| to integrate with OmegaT. | ||
|
|
||
| This document provides guidance on creating a plugin, explaining the purpose of the interface methods, |
There was a problem hiding this comment.
The overview section should also explain the abstract classes and how to register Spell checker dictionary provider into OmegaT core when loading the plugins.
…language-module # Conflicts: # src/org/omegat/gui/dialogs/DictionaryInstallerDialog.java
@Kazephil Could you take a look please? |
- I tried to reword the paragraph to flow more smoothly. Let me know if anything seems off. - I agree with Jean-Christophe about the developer manual reference, so I simply deleted it here. We will have to give some thought about how and where we can best make that information available.
doc_src/en/OmegaT_Preferences.xml
Outdated
There was a problem hiding this comment.
It looks like my rewording came through, but not my comments.
I tried to reword the paragraph to flow more smoothly, and I removed the line about the developer manual. On that last point, I agree with Jean-Christophe both that having it is a good idea, and that this isn't the place for it.
We'll have to give some thought to how and where to best present information that directs the reader to the developer manual.
There was a problem hiding this comment.
We'll have to give some thought to how and where to best present information that directs the reader to the developer manual.
I think it is out of scope of the PR here, and lets discuss in dev-ML.
- fix section levels - update overview section Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
|
Acceptance test is flaky. It does not depend on the issue. |
LanguageTool bundles hunspell or morfologik dictionary in language libraries.
This add new API to access these dictionary from spellchecker module.
Pull request type
Which ticket is resolved?
What does this PR change?
o.o.c.spellchecker.ISpellCheckerDictionaryinterfaceo.o.c.s.AbstractMorfologikDictionaryando.o.c.s.AbstractHunspellDictionaryclassesOther information
This feature depends on another PR, #1183