feat: EditorUtils use document's locale to splitting words #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
changed the title
- Update javadoc for getWordEnd and getWordStart utility functions - Remove "TODO: change to use document's locale" - grab word with source and target locale of the project Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/gui/editor/utils-clean-todo-word-boundary-locale
branch
from
408b494 to
4f429dc
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
- test EditorUtils.getWord* with loaded project from Chinese to Japanese in English environment Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
…word-boundary-locale
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
changed the title
miurahr
commented
Dec 1, 2024
miurahr
commented
Dec 1, 2024
- Add unit test for getBoundary method with English, Japanese and Chinese Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Dec 2, 2024
Signed-off-by: Hiroshi Miura <[email protected]>
- Update javadoc - @deprecated for methods with old signature - Simplify some lines Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
…word-boundary-locale
|
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
…word-boundary-locale # Conflicts: # gradle/libs.versions.toml
…lean-todo-word-boundary-locale' into topic/miurahr/gui/editor/utils-clean-todo-word-boundary-locale
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Dec 12, 2024
miurahr
commented
Dec 12, 2024
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
deleted the
topic/miurahr/gui/editor/utils-clean-todo-word-boundary-locale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many TODO comments in the source.
This try to implement one of TODO in EditorUtils class.
Pull request type
Please mark github LABEL of the type of change your PR introduces:
Which ticket is resolved?
What does this PR change?
Other information
TODO