Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduction of language modules #1090

Closed

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Jul 25, 2024

Hack to LanguageTool to allow modularization of each language-* libraries as plugin modules.

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

  • Introduce LanguageToolDataBroker and LanguageToolClassBroker classes for LT libraries to access module classes.
  • Introduce LanguageToolLanugageManager to allow omegat-language modules to register LT languages.

Other information

Use forked version of [email protected]

Signed-off-by: Hiroshi Miura <[email protected]>
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/b27zzzldycga6

@miurahr miurahr force-pushed the topic/miurahr/languagetool/language-module-6.3omt1.0 branch from 9173659 to a05793b Compare July 25, 2024 05:14
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/uwome6stjiwpk

- add LanguageToolLanguageManager: Language plugins should register LT language with LanguageToolLanguageManager.registerLTLanguage for supporting module

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/languagetool/language-module-6.3omt1.0 branch from a05793b to 5877f5c Compare July 25, 2024 05:26
@miurahr miurahr closed this Jul 25, 2024
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/g4uyrav2rrwre

…3-omt1.0' into topic/miurahr/languagetool/language-module-6.3omt1.0

# Conflicts:
#	build.gradle
#	languagetools/build.gradle
@miurahr miurahr reopened this Jul 25, 2024
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:

1 similar comment
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:

@miurahr miurahr closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant