Add funding logos #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngff-challenge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
will-moore
reviewed
Nov 12, 2024
| <table> | ||
| <tr> | ||
| <td><img src="nfdi_rgb_Wortmarke_Zusatz_quer.png" width="45%"/></td> | ||
| <td><img src="czi-logo-chan-zuckerberg-initiative-logo.png" width="45%"/></td> |
There was a problem hiding this comment.
I was going to say that this won't work when deployed on github, and suggest that you need to do it as in Nav.svelte:
import omeMainNav from "/ome-main-nav.svg";
...
<img alt="OME Logo" src={omeMainNav} />
But I just pushed this branch to my 'main' branch so it's deployed at https://will-moore.github.io/ome2024-ngff-challenge/about/ and it's fine!
The approach I used for Nav is possibly a bit more robust since it generates an absolute URL, but actually this is working fine so 👍
There was a problem hiding this comment.
Looks to be working. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.