Store statistics in array metadata #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the key _ome2024_ngff_challenge_stats we now store
the following statistics for each array conversion:
- input: endpoint of the input location, "default", or "" if not s3
- output: endpoint of the output location, "default", or "" if not s3
- read: total bytes read
- written: total bytes written
- start: epoch at which the conversion started
- stop: epoch at which the conversion stopped
- elapsed: equals "stop - start"
For example:
```
"attributes": {
"_ome2024_ngff_challenge_stats": {
"input": "https://uk1s3.embassy.ebi.ac.uk",
"output": "",
"start": 1724228072.7066,
"stop": 1724228073.515819,
"read": 2312282,
"written": 1661288,
"elapsed": 0.8092191219329834
}
```
|
Thanks. Merging to get the metadata work discussed during this morning's challenge chat opened before the afternoon session. |
|
@perlman suggestions something like
|
joshmoore
added a commit
to joshmoore/ome2024-ngff-challenge
that referenced
this pull request
Aug 22, 2024
As discussed during the challenge meeting, a few additional fields would be useful for evaluating. These are now stored (somewhat redundantly) in each stats block. Additionally, a new argument `--conversion-notes` adds text to the _creator field. This does not yet record memory usage. `psutil` will need adding for cross-platform checks. see: ome#31 (comment)
|
Opened #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the key _ome2024_ngff_challenge_stats we now store the following statistics for each array conversion:
For example: