Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(FileImageGenerator): remove extrac-file-icon dependency #1075

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Fix(FileImageGenerator): remove extrac-file-icon dependency #1075

merged 9 commits into from
Mar 4, 2024

Conversation

oliverschwendener
Copy link
Owner

@oliverschwendener oliverschwendener commented Mar 4, 2024 •
edited
Loading

This PR serves the objective of getting rid of the extract-file-icon depedency for the following reasons:

  • It was unreliable on Windows
  • Did not work on Linux at all

Outstanding work:

  • Remove extrac-file-icon dependency
  • Use app.getFileIcon to generate icons
  • Add icon extractors for apps on
    • macOS
    • Windows
  • Add custom icon generation for folders on
    • macOS
    • Windows

@oliverschwendener oliverschwendener self-assigned this Mar 4, 2024
@oliverschwendener oliverschwendener mentioned this pull request Mar 4, 2024
Closed
@oliverschwendener oliverschwendener merged commit f923aeb into main Mar 4, 2024
1 check passed
@oliverschwendener oliverschwendener deleted the extract-file-icon-removal branch March 4, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverschwendener oliverschwendener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverschwendener