Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix currency-api link #1071

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fix currency-api link #1071

merged 1 commit into from
Mar 2, 2024

Conversation

fawazahmed0
Copy link
Contributor

No description provided.

@wywywywy
Copy link
Contributor

wywywywy commented Mar 1, 2024

Is it worth adding the Cloudflare URL in as fallback as well?

@fawazahmed0
Copy link
Contributor Author

fawazahmed0 commented Mar 1, 2024 •
edited
Loading

Yes, definitely. For example, in another PR I have added cloudflare URL, as the code supported adding fallback

@oliverschwendener
Copy link
Owner

What's the issue? Can you add a more detailed description?

@fawazahmed0
Copy link
Contributor Author

fawazahmed0 commented Mar 2, 2024 •
edited
Loading

currency-api repository has been migrated. Reason for migration is here

@oliverschwendener
Copy link
Owner

Ah sorry, I didn't realize that this is a PR 😅. Looks good, thanks for your contribution! (1st one on the v9 code base)

@oliverschwendener oliverschwendener merged commit 03e1ccd into oliverschwendener:main Mar 2, 2024
1 check passed
@oliverschwendener oliverschwendener mentioned this pull request Mar 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschwendener oliverschwendener oliverschwendener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fawazahmed0 @wywywywy @oliverschwendener