Refactored Get-Associated-Icon function to handle file path errors (#…

…1096) * Refactored Get-Associated-Icon function to handle file path errors * Just do nothing when icon extraction failed --------- Co-authored-by: Oliver Schwendener <[email protected]>
oliverschwendener · May 11, 2024 · 8b6962c · 8b6962c
1 parent 40c9b14
commit 8b6962c
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/main/Core/ImageGenerator/Windows/powershellScripts.ts b/src/main/Core/ImageGenerator/Windows/powershellScripts.ts
@@ -30,9 +30,15 @@ function Get-Associated-Icon {
         $InFilePath = Get-Shortcut-Target -ShortcutFilePath $InFilePath
     }
 
-    $Icon = [System.Drawing.Icon]::ExtractAssociatedIcon($InFilePath)
+    # ExtractAssociatedIcon will crash if the file path contains special characters
+    # e.g. "Über iTunes" will crash the script and thus no search results are shown
+    try {
+        $Icon = [System.Drawing.Icon]::ExtractAssociatedIcon($InFilePath)
 
-    if ($Icon -ne $null) {
-        $Icon.ToBitmap().Save($OutFilePath, [System.Drawing.Imaging.ImageFormat]::Png)
+        if ($null -ne $Icon) {
+            $Icon.ToBitmap().Save($OutFilePath, [System.Drawing.Imaging.ImageFormat]::Png)
+        }
+    } catch {
+        # Do nothing and continue
     }
 }`;