Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range query: Follow latest DSL #1187

Open
wants to merge 1 commit into
base: release-branch.v7
Choose a base branch
from

Conversation

and1truong
Copy link
Contributor

@and1truong and1truong commented Sep 17, 2019

DSL for branch 7.x already changed, from/to/include_lower/include_upper are gone:

https://www.elastic.co/guide/en/elasticsearch/reference/7.0/query-dsl-range-query.html

@and1truong and1truong force-pushed the query-range branch 4 times, most recently from 458f527 to 0259048 Compare September 17, 2019 05:45
@olivere olivere added this to the 7.0.8 milestone Oct 4, 2019
@olivere
Copy link
Owner

olivere commented Oct 4, 2019

Although I agree that gt and gte are more intuitive, the old way of doing things are still alive and kicking.

I won't merge this PR in its current form as it breaks existing clients that rely on IncludeUpper and IncludeLower.

@olivere
Copy link
Owner

olivere commented Oct 6, 2019

I've checked 6.8.3 and 7.4.0, and both seem to be able to parse gt and gte correctly, so I think we can move forward with this change. Both seem to be supported since at least 6.0.0.

@olivere olivere modified the milestones: 7.0.8, 7.0.9 Oct 14, 2019
@olivere olivere modified the milestones: 7.0.9, 7.0.10 Nov 4, 2019
@olivere olivere modified the milestones: 7.0.10, 7.0.11 Jan 4, 2020
@olivere olivere modified the milestones: 7.0.11, 7.0.12 Feb 7, 2020
@olivere olivere modified the milestones: 7.0.12, 7.0.13 Feb 27, 2020
@olivere olivere modified the milestones: 7.0.13, 7.0.14 Mar 27, 2020
@olivere olivere modified the milestones: 7.0.14, 7.0.15 Apr 10, 2020
@olivere olivere modified the milestones: 7.0.15, 7.0.16 May 1, 2020
@olivere olivere modified the milestones: 7.0.16, 7.0.17, 7.0.18 Jun 2, 2020
@olivere olivere modified the milestones: 7.0.18, 7.0.19 Jul 13, 2020
@olivere olivere modified the milestones: 7.0.19, 7.0.20 Jul 25, 2020
@olivere olivere modified the milestones: 7.0.20, 7.0.21 Aug 30, 2020
@olivere olivere modified the milestones: 7.0.21, 7.x Oct 16, 2020
@houz42
Copy link

houz42 commented Sep 29, 2021

@olivere thanks for your great work, and I wonder why this pr is open for nearly a year after all check passed. IMO this is a really important change, and at least in ES 7.10, the old params are already deprecated. We really need this when using newer servers. Is there any more work need to do, or any help could be useful?

@olivere
Copy link
Owner

olivere commented Sep 29, 2021

@houz42 Thanks for the kind words.

The reason is that there was just no need to rush. Even the Java code in 7.15 generates the range fields with the old syntax. See for youself. So in the end, it's just what happens on the wire. The actual outcome is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants