-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range query: Follow latest DSL #1187
base: release-branch.v7
Are you sure you want to change the base?
Conversation
458f527
to
0259048
Compare
0259048
to
4e28ea6
Compare
Although I agree that I won't merge this PR in its current form as it breaks existing clients that rely on |
I've checked 6.8.3 and 7.4.0, and both seem to be able to parse |
@olivere thanks for your great work, and I wonder why this pr is open for nearly a year after all check passed. IMO this is a really important change, and at least in ES 7.10, the old params are already deprecated. We really need this when using newer servers. Is there any more work need to do, or any help could be useful? |
@houz42 Thanks for the kind words. The reason is that there was just no need to rush. Even the Java code in 7.15 generates the range fields with the old syntax. See for youself. So in the end, it's just what happens on the wire. The actual outcome is the same. |
DSL for branch 7.x already changed, from/to/include_lower/include_upper are gone:
https://www.elastic.co/guide/en/elasticsearch/reference/7.0/query-dsl-range-query.html