Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

[okta-react] fixes SecureRoute to only run logic if route matches #903

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Sep 9, 2020

Related issues:
#902
#888

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: OKTA-328767

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@aarongranick-okta aarongranick-okta force-pushed the ag-OKTA-328767-route-match branch from 9b5569e to e3f6024 Compare September 9, 2020 23:05
@aarongranick-okta aarongranick-okta merged commit 815472e into master Sep 10, 2020
@aarongranick-okta aarongranick-okta deleted the ag-OKTA-328767-route-match branch September 10, 2020 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants