Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVM prompt #207

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Add NVM prompt #207

merged 3 commits into from
Jul 1, 2019

Conversation

alessandro-fazzi
Copy link
Contributor

@alessandro-fazzi alessandro-fazzi commented Jun 26, 2019

As it says. Should fix #97

Sincerly I'm not 100% sure about colors I've used for all the themes: I chose the green and applied it down to all the supported color schemes.

Since this is a PR on a project I do not maintain, I decided to have this prompt disabled by default.

If NVM version is deactivated (nvm deactivate) the nvm prompt won't show. I'm open to other/smarter methods to understand if we're not on an nvm's node version.

Documentation should be ok also.

Note: this is a specific PR done for NVM, hence it's not meant to supersede the (stalled?) #128

@alessandro-fazzi
Copy link
Contributor Author

Sry for the push-force, but I've rebased after a fixup in order to retain clean history: I left a debug echo in the code. My bad.

@alessandro-fazzi
Copy link
Contributor Author

I've opted to not show the prompt also if system version is used

Copy link
Member

@bobthecow bobthecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

That's the approach I usually take to colors :)

functions/__bobthefish_glyphs.fish Outdated Show resolved Hide resolved
@bobthecow bobthecow merged commit 1abb331 into oh-my-fish:master Jul 1, 2019
@bobthecow
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NVM support
2 participants