Master error mounted ged #1655
Merged
Master error mounted ged #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ged-odoo
force-pushed
the
master-error-mounted-ged
branch
4 times, most recently
from
77f2517 to
bc63592
Compare
The error recovery process is necessary, but is particularly subtle. An error may occur basically any time some user code is called, which may leave the internal owl state in an invalid situation. In this commit, we try to improve Owl behaviour when a crash occurs in a onMounted hook. Before this commit, it was possible for other component mounted hooks to be called even though the component was not mounted, or for willUnmount hooks to be called even though the component was mounted, but its onMounted hooks had not been called. All these situations need to be handled when we catch an error. In this commit, we try to clean more internal state in the error handling code, to make Owl more consistent.
ged-odoo
force-pushed
the
master-error-mounted-ged
branch
from
bc63592 to
d112e19
Compare
jpp-odoo
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.