Restrict matplotlib version #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyrss
approved these changes
Dec 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 59.05% 59.19% +0.13%
==========================================
Files 23 23
Lines 5009 5009
==========================================
+ Hits 2958 2965 +7
+ Misses 2051 2044 -7 ☔ View full report in Codecov by Sentry. |
burnout87
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incompatibility between
astropyand recentmatplotlib.It seems that a fix for this incompatibility hasn't been backported to the versions of
astropywe rely on (astropyis currently restricted in our dependencies).It hasn't been observed directly with
oda_apiitself, but @andriineronov encountered a problem in the environment wheregammapyis also present. So to be on a safe side, I propose to restrict it as well.NOTE: don't forget to restrict in conda package as well.