Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic hierarchy #281

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Generic hierarchy #281

merged 4 commits into from
Oct 2, 2024

Conversation

dsavchenko
Copy link
Member

@dsavchenko dsavchenko commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.05%. Comparing base (02e47e3) to head (9157b82).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
oda_api/ontology_helper.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   59.00%   59.05%   +0.04%     
==========================================
  Files          23       23              
  Lines        4945     4953       +8     
==========================================
+ Hits         2918     2925       +7     
- Misses       2027     2028       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsavchenko
Copy link
Member Author

Something wrong with live tests. @volodymyrss is this server-side issue?

Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a test?

@dsavchenko
Copy link
Member Author

could you please add a test?

A particular case of parameter hierarchy has been there for a long time. I just made a method to be more generic.

@volodymyrss volodymyrss merged commit 0f2969c into master Oct 2, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants