get_requested_resources method was added to Ontology

[okolo]

Note, that I have temporarily changed the url of the ontology file to https://raw.githubusercontent.com/oda-hub/ontology/storage_resource_annotations/ontology.ttl in python-package.yml . This is needed for unit tests. As soon as ontology pull request is done the change in python-package.yml should be reverted.

[codecov]

Codecov Report

Attention: Patch coverage is 97.82609% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.82%. Comparing base (c889b20) to head (a9aa0c1).

Files	Patch %	Lines
oda_api/ontology_helper.py	97.22%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   58.30%   58.82%   +0.52%     
==========================================
  Files          23       23              
  Lines        4849     4894      +45     
==========================================
+ Hits         2827     2879      +52     
+ Misses       2022     2015       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsavchenko]

Some concerns about performance due to creation of the additional graph (L450) and using a recursive function in the loop. (But I'm not really sure if the approach of complex SPARQL queries I use elsewhere is really better.)

Given that this method will be used once upon deployment, that's not a big problem.

[okolo]

The tests do not pass due to error in test_plot_tools_notebook, which has nothing to do with get_requested_resources

[volodymyrss]

The tests do not pass due to error in test_plot_tools_notebook, which has nothing to do with get_requested_resources

What is the error? If you notice it, could you make an issue? If it's complex to fix it quickly, please mark the tests skipped.

[dsavchenko]

What is the error? If you notice it, could you make an issue? If it's complex to fix it quickly, please mark the tests skipped.

This was some transient issue with the prod instance, I think. Fixed by rerunning. Could you merge, nb2workflow now depends on this change in master

[dsavchenko]

Could you merge

@volodymyrss