ImGui_ImplAllegro5_UpdateMouseCursor should not create a new cursor each frame #8256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ImGui sends a call to Allegro each time a frame is drawn, either reusing a stored invisible cursor or creating a new system cursor.
Allegro currently has a memory leak in its X11 interface (see this Allegro PR) where system cursors are not cleared when a new one is generated. This paired with creating a new cursor each frame results in a leak that results in an XWayland abort within 10 minutes (see this xorg bug report)
This fix reduces the amount of unnecessary cursor creations by caching which cursor is currently being rendered, and only creating a new one when it changes. This does not fix the memory leak, but heavily mitigates its effect.