Playback: Check outgoing traffic if it matches what is recorded in VCR tape + check if test source code changed + remove non-gzip vcr tape compat #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
megies
added a commit
to obspy/obspy
that referenced
this pull request
Apr 3, 2017
megies
changed the title
megies
changed the title
megies
force-pushed
the
check_outgoing_traffic
branch
from
2cfda16 to
2f2e1d0
Compare
|
Handling of start/stop need cleaning up, I think. That's probably why this fails, although it has no vcr decorator: https://travis-ci.org/obspy/vcr/jobs/218428957#L462 Oh and yeah, I did not update vcr tapes yet.. will do later.. |
megies
added a commit
to obspy/obspy
that referenced
this pull request
Apr 5, 2017
|
Ok, so since the context manager was added on master I will get rid of b602658 again and rebase on master.. |
|
Rebased on current master and force-pushed. Hope I didn't mess up, change to context manager made some conflict resolving necessary.. commit hash before rebase was 5a4b8ee. |
megies
force-pushed
the
check_outgoing_traffic
branch
2 times, most recently
from
53cf697 to
c5092f0
Compare
|
Rebased and force-pushed.. tests should pass now hopefully ;-) |
megies
added a commit
to obspy/obspy
that referenced
this pull request
Apr 7, 2017
also add soem more debug output
outgoing traffic check during playback
megies
force-pushed
the
check_outgoing_traffic
branch
from
e4b5b85 to
a5be0e0
Compare
|
All but one test pass locally on Linux Python 3.6 |
changed since time of vcr tape recording
actual outgoing traffic is sent
tapes anyway, so there will be no valid old vcr tapes around
tests, also after reset() in test code
megies
force-pushed
the
check_outgoing_traffic
branch
from
a5be0e0 to
74bb27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checking outgoing traffic during playback. This is sorely needed, otherwise code can be broken (e.g. sending malformed results), while VCR playback based tests pass (because incoming traffic is replayed not regarding if the request was valid).
This needs some mechanics to normalize actual/pre-recorded outgoing traffic before comparing the two. I'm open to suggestions for handling this differently as implemented right now.
This also introduces some exception classes.
No tests for this right now, but it works in real world ..
This now also adds the missing detail of making sure that test code (whether doctest examples or unittest test method) did not change from recording time to playback time. Otherwise the executed client side API calls might not match the VCR recording anymore.