remove unused exports? #2051
Draft
remove unused exports? #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> npx ts-unused-exports tsconfig.json src/**/*.js src/**/*ts test/**/*.js test/**/*.ts
Fil
commented
Apr 11, 2024
| @@ -14,7 +14,7 @@ const weekdayFormat = memoize1((locale, weekday) => { | |||
| return new Intl.DateTimeFormat(locale, {timeZone: "UTC", ...(weekday && {weekday})}); | |||
| }); | |||
|
|
|||
| export function formatNumber(locale = "en-US") { | |||
| function formatNumber(locale) { | |||
There was a problem hiding this comment.
here I learned that we don't need to set the default locale (cf. #384) in this function, since it's only called from formatAuto.
| @@ -50,12 +50,10 @@ export const singleton = [null]; // for data-less decoration marks, e.g. frame | |||
| export const field = (name) => (d) => d[name]; | |||
| export const indexOf = {transform: range}; | |||
| export const identity = {transform: (d) => d}; | |||
| export const zero = () => 0; | |||
There was a problem hiding this comment.
this seems to be here for consistency only
| export const one = () => 1; | ||
| export const yes = () => true; | ||
| export const string = (x) => (x == null ? x : `${x}`); | ||
| export const number = (x) => (x == null ? x : +x); | ||
| export const boolean = (x) => (x == null ? x : !!x); |
There was a problem hiding this comment.
this seems to be here for consistency only
| @@ -225,11 +223,6 @@ export function range(data) { | |||
| return r; | |||
| } | |||
|
|
|||
| // Returns a filtered range of data given the test function. | |||
| export function ibetainv(p, a, b) { | ||
| function ibetainv(p, a, b) { |
There was a problem hiding this comment.
this file is an external library, we might not want to mess with it too much
mbostock
reviewed
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I obtained the list with:
> npx ts-unused-exports tsconfig.json src/**/*.js src/**/*ts test/**/*.js test/**/*.tsNot sure we need to remove all of this? Some things seem to be here for consistency.