Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt adding taxon constraint QC back #2388

Closed
wants to merge 3 commits into from

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Apr 8, 2022

Fixes #2374

@matentzn
Copy link
Contributor Author

matentzn commented Apr 8, 2022

@shawntanzk if you have time, can you check out this PR and add an xref that would (or should) definitely break the taxon constraints rules? Seems like the ZFA one that previously broke stuff doesn't today. Wanna make sure that something still breaks.

@shawntanzk
Copy link
Collaborator

happy to, but not sure what this QC does and what I should be looking out for

@matentzn
Copy link
Contributor Author

matentzn commented Apr 8, 2022

Dont worry about the qc.. Just add a cross reference that would 100% break the rules, like a fishy reference to something that can only be in humans.

@github-actions
Copy link

github-actions bot commented May 9, 2022

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

uterine horn http://purl.obolibrary.org/obo/UBERON_0002247

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

uterine horn http://purl.obolibrary.org/obo/UBERON_0002247

Added

@shawntanzk shawntanzk self-assigned this Aug 9, 2022
@shawntanzk
Copy link
Collaborator

@matentzn - can I remove the fake ZFA xref now? Happy to update this to latest branch and if it passes stick the check back in :D

@matentzn
Copy link
Contributor Author

As opposed to all other PRs, this PR is only to be considered successful if it fails, not of it passes. Raise a future tech call, need someone to look why its not failing

@shawntanzk
Copy link
Collaborator

wwhatttt ok yeah, it failed when i last looked, must have been something else

@github-actions
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

@shawntanzk shawntanzk marked this pull request as draft October 17, 2022 13:41
@anitacaron
Copy link
Collaborator

Superseded by #2928

@anitacaron anitacaron closed this Sep 15, 2023
@anitacaron anitacaron deleted the issue2374-taxconstraint1 branch March 22, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include proper taxon constrait checking in general CI
3 participants