-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt adding taxon constraint QC back #2388
Conversation
@shawntanzk if you have time, can you check out this PR and add an xref that would (or should) definitely break the taxon constraints rules? Seems like the ZFA one that previously broke stuff doesn't today. Wanna make sure that something still breaks. |
happy to, but not sure what this QC does and what I should be looking out for |
Dont worry about the qc.. Just add a cross reference that would 100% break the rules, like a fishy reference to something that can only be in humans. |
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsuterine horn
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsuterine horn
|
@matentzn - can I remove the fake ZFA xref now? Happy to update this to latest branch and if it passes stick the check back in :D |
As opposed to all other PRs, this PR is only to be considered successful if it fails, not of it passes. Raise a future tech call, need someone to look why its not failing |
wwhatttt ok yeah, it failed when i last looked, must have been something else |
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Superseded by #2928 |
Fixes #2374