-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated allen atlases #1406
base: master
Are you sure you want to change the base?
Conversation
Who would be an appropriate reviewer for this PR? @cmungall |
The MBA changes look ok to me. The ids are more or less completely arbitrary at this point (much to the consternation of some atlas implementers), still no change to the fact that all the ontology ids share the same uri prefix in the Allen api (http://api.brain-map.org/api/v2/data/Structure/). |
If to be moved forward needs to be aligned with new Makefile structure. Can help but needs driver. |
ABA Uberon mappings are important for the Brain Data Standards grant, so work can be done @hkir-dev (+ Shawn & Allen representatives if needed). This is currently low on our priority list so won't happen straight away. We should organise a call to work out what needs to be done. Can be after summer. |
Presumably we can close here? For all 5 Allen atlases (HBA / DHBA / MBA / DMBA / PBA) that we include in As for the addition of the “glioblastoma” atlas:
|
Note there is a spurious diff in here - it makes it look like some IDs were deleted; just order shuffling (sorry, should have normalized ordering)