Feature/angular-http-auth #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property is present
ruipenso
requested changes
Nov 23, 2017
dylanbr
force-pushed
the
feature/angular-http-auth
branch
from
527fdeb to
899666b
Compare
|
Removed the new build (dist files) from the pull request. |
|
The build error is unrelated to this pull request. Something has broken "npm install":
|
|
I've logged an issue with nikku/karma-browserify about this nikku/karma-browserify#213 |
Closed
|
@dylanbr , this is not @nikku's fault. I think this is because browserify used to be called node-browserify and got renamed recently.. They forgot to change their |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for integration with witoldsz/angular-http-auth.
When angular-http-auth plays back paused calls after a refresh, there is already an Authorization header within the request. This needs to be overridden with the new Authorization header when the call is recreated.
In order to still allow requests for access and refresh tokens to take place, this check will not replace the header if a config.header.Authorization property exists with a value of undefined.