Added guid property for root level log (#483) #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Hagen <[email protected]>
sthagen
added
the
design-approved
|
Will the JSON schema be updated in a separate pull request? https://github.com/oasis-tcs/sarif-spec/blob/main/sarif-2.2/schema/sarif-2-2.schema.json |
- Added the guid member to the root level object in the schema (thanks to Kalle Olavi Niemitalo for reminding) - Softened the compliance level to SHOULD as a compromise to mitigate the impact on slow adapters. Signed-off-by: Stefan Hagen <[email protected]>
|
The motion to approve and merge this pull request succeeded during the 2024-07-11 TC meeting. Cf. 3.3.2 Approval of changes after merge of the minutes PR, until then https://github.com/oasis-tcs/sarif-spec/blob/meeting-2024-07-11/meeting_minutes/240711_SARIF_TC_89.md#332-approval-of-changes. The preceding discussion showed a need to better describe use cases and implication of the diverse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #483