Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding allOf to PAP schema and adding PAP:CLEAR #73

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

ghackford-mitre
Copy link
Contributor

This PR adds PAP:CLEAR to the examples, schema, and adoc files. It also adds an AllOf clause to the PAP JSON schema. Per conversation with Chris, there may be some differences in the PAP schema in contrast to the CUI schema for a couple reasons. The CUI spec explicitly restricts some items, such as definition_type, while the PAP spec does not. However, both schemas include required elements in the AllOf clause e.g. properties, required, etc.

@rpiazza
Copy link
Contributor

rpiazza commented Mar 16, 2024

@clenk @ghackford-mitre,

The CUI spec explicitly restricts some items, such as definition_type, while the PAP spec does not.

Those properties are deprecated, and shouldn't be used with extension definitions. If the PAP spec doesn't explicitly say the same thing as the CUI one, we should update the PAP spec.

@rpiazza
Copy link
Contributor

rpiazza commented Mar 16, 2024

Also I have never seen "$definitions". If should be just "definitions".

Also, drop the Word doc file - we won't be keeping that up to date

@ghackford-mitre
Copy link
Contributor Author

Regarding "definitions" - My IDE gives me a big warning when using "definitions" saying that value is deprecated. Checking up on it, I found this: https://json-schema.org/draft/2019-09/release-notes#semi-incompatible-changes. Should I still use regular "definitions" over "$defs" for consistency with the other schema?

@rpiazza
Copy link
Contributor

rpiazza commented Mar 18, 2024

I guess we will go with $defs :-)

@rpiazza rpiazza merged commit a3d8ae6 into oasis-open:main Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants